cabal2nix: resolve crypt library to libxcrypt#576
Merged
sternenseemann merged 1 commit intomasterfrom Oct 22, 2022
Merged
Conversation
NixOS has disabled glibc's libcrypt and is using libxcrypt now (starting with 22.11, that is): NixOS/nixpkgs#181764 This means we'll need to resolve the crypt identifier to libxcrypt. Releases including this commit need to go into NixOS unstable (as soon as the current staging iteration has finished) and NixOS 22.11. A release including this commit *may not* be backported to 22.05, as it'd likely break builds there.
cdepillabout
approved these changes
Oct 11, 2022
Member
cdepillabout
left a comment
There was a problem hiding this comment.
This looks reasonable to me.
Great that one of our golden tests covered this as well.
5 tasks
Member
Author
|
Tested on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NixOS has disabled glibc's libcrypt and is using libxcrypt now (starting with 22.11, that is): NixOS/nixpkgs#181764
This means we'll need to resolve the crypt identifier to libxcrypt. Releases including this commit need to go into NixOS unstable (as soon as the current staging iteration has finished) and NixOS 22.11. A release including this commit may not be backported to 22.05, as it'd likely break builds there.