next release v2.6.0 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Member
|
from me it is all good |
Member
Author
|
Pushed lots of fixes, but left some errors (see https://github.com/NiftyPET/NIMPA/actions/runs/5193633461/jobs/9364422220) because I'm unsure about them |
6d52f61 to
700f7cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 7.84% 10.98% +3.13%
==========================================
Files 9 16 +7
Lines 2102 3131 +1029
==========================================
+ Hits 165 344 +179
- Misses 1937 2787 +850
|
casperdcl
commented
Jun 20, 2023
| ''' | ||
| # possible DICOM file extensions | ||
| ext = ('dcm', 'DCM', 'ima', 'IMA') | ||
| ext = 'dcm', 'ima' |
Member
Author
There was a problem hiding this comment.
btw can this use dcmext ('dcm', 'ima', 'img') instead?
| for f in chain(outdir.glob('*.nii*'), outdir.glob('*.json')): | ||
| # remove previous files | ||
| os.remove(f) | ||
| run([dcm2niix.bin, '-i', 'y', '-v', 'n', '-o', outdir, '-f', '%f_%s', str(indat)]) |
Member
Author
There was a problem hiding this comment.
this was 'f', '%f_%s' instead of '-f', '%f_%s'. Presumably latter is correct.
Member
Author
|
/tag v2.6.0 f80a3d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acrmoduleimg.signamoduleprc&imgupdatespkg_resources=>importlib_resourcessetup.cfg=>pyproject.toml