next release v2.5.0 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er by description or by descritpion + time
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
- Coverage 10.11% 7.89% -2.23%
=========================================
Files 9 9
Lines 1978 2091 +113
=========================================
- Hits 200 165 -35
- Misses 1778 1926 +148
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
casperdcl
commented
Aug 17, 2022
Comment on lines
+65
to
+68
| while txt[0] == replacement_char: | ||
| txt = txt[1:] | ||
|
|
||
| return txt |
Member
Author
There was a problem hiding this comment.
Suggested change
| while txt[0] == replacement_char: | |
| txt = txt[1:] | |
| return txt | |
| return txt.lstrip(replacement_char) |
casperdcl
commented
Aug 17, 2022
|
|
||
| if [0x018, 0x1079] in tinf: | ||
| tmp = tinf[0x018, 0x1079].value | ||
| val = tinf[0x018, 0x1079].value |
Member
Author
There was a problem hiding this comment.
I assume this is correct?
Member
Author
|
/tag v2.5.0 622212c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.