Skip to content

remove redundant code #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperdcl merged 2 commits into from
Sep 27, 2021
Merged

remove redundant code #19

casperdcl merged 2 commits into from
Sep 27, 2021

Conversation

@casperdcl
Copy link
Member

@casperdcl casperdcl commented Sep 26, 2021 •
edited
Loading

  • remove unneeded conv logic

@casperdcl casperdcl self-assigned this Sep 26, 2021
@casperdcl casperdcl requested a review from pjmark September 26, 2021 15:48
@casperdcl casperdcl changed the base branch from master to devel September 26, 2021 15:48
@casperdcl casperdcl added the enhancement New feature or request label Sep 26, 2021
@casperdcl casperdcl mentioned this pull request Sep 26, 2021
Merged
@codecov
Copy link

codecov bot commented Sep 26, 2021 •
edited
Loading

Codecov Report

Merging #19 (2c71fb3) into devel (a06b67f) will increase coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           devel     #19      +/-   ##
========================================
+ Coverage   8.43%   8.50%   +0.07%     
========================================
  Files          7       7              
  Lines       1779    1775       -4     
========================================
+ Hits         150     151       +1     
+ Misses      1629    1624       -5
Impacted Files Coverage Δ
niftypet/nimpa/prc/prc.py 10.51% <33.33%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06b67f...2c71fb3. Read the comment docs.

casperdcl
casperdcl commented Sep 27, 2021
View reviewed changes
@casperdcl casperdcl mentioned this pull request Sep 27, 2021
Merged
@casperdcl casperdcl merged commit 22da22b into devel Sep 27, 2021
@casperdcl casperdcl deleted the conv-tidy branch September 27, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjmark pjmark Awaiting requested review from pjmark

Assignees

@casperdcl casperdcl

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@casperdcl