Skip to content

C++/CUDA: replace numpy => cuvec #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperdcl merged 16 commits into from
Jan 21, 2021
Merged

C++/CUDA: replace numpy => cuvec #16

casperdcl merged 16 commits into from
Jan 21, 2021

Conversation

@casperdcl
Copy link
Member

@casperdcl casperdcl commented Jan 17, 2021 •
edited
Loading

  • use https://github.com/AMYPAD/cuvec instead of numpy arrays (avoids all unnecessary memory copies)
  • allow arbitrary 3D input dimensions (auto-pad)
  • add tests
  • ensure can still build without CUDA

@casperdcl casperdcl added the enhancement New feature or request label Jan 17, 2021
@casperdcl casperdcl requested a review from pjmark January 17, 2021 04:05
@casperdcl casperdcl self-assigned this Jan 17, 2021
@casperdcl casperdcl changed the base branch from master to devel January 17, 2021 04:05
@codecov
Copy link

codecov bot commented Jan 17, 2021 •
edited
Loading

Codecov Report

Merging #16 (8068d96) into devel (1d46bf1) will increase coverage by 0.03%.
The diff coverage is 10.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           devel     #16      +/-   ##
========================================
+ Coverage   6.80%   6.84%   +0.03%     
========================================
  Files          7       7              
  Lines       1704    1710       +6     
========================================
+ Hits         116     117       +1     
- Misses      1588    1593       +5
Impacted Files Coverage Δ
niftypet/nimpa/prc/prc.py 6.39% <10.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d46bf1...6d08de9. Read the comment docs.

@casperdcl casperdcl merged commit a4e8125 into devel Jan 21, 2021
@casperdcl casperdcl deleted the cuvec branch January 21, 2021 03:23
@casperdcl casperdcl mentioned this pull request Jan 21, 2021
Merged
@casperdcl casperdcl mentioned this pull request Feb 1, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjmark pjmark Awaiting requested review from pjmark

Assignees

@casperdcl casperdcl

Labels

enhancement New feature or request framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@casperdcl