Skip to content

fix bugs & formatting #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
casperdcl merged 12 commits into from
Jan 6, 2021
Merged

fix bugs & formatting #13

casperdcl merged 12 commits into from
Jan 6, 2021

Conversation

@casperdcl
Copy link
Member

@casperdcl casperdcl commented Jan 5, 2021 •
edited
Loading

  • fix basic bugs
  • don't build install_tools on sdist
  • remove unused code
  • automate formatting & basic bug detection
  • add PR tests & comments

@casperdcl casperdcl added bug Something isn't working enhancement New feature or request labels Jan 5, 2021
@casperdcl casperdcl self-assigned this Jan 5, 2021
@casperdcl casperdcl force-pushed the devel branch 2 times, most recently from be545a9 to 230c1d0 Compare January 5, 2021 16:58
@casperdcl casperdcl marked this pull request as ready for review January 5, 2021 17:06
@casperdcl casperdcl requested a review from pjmark January 5, 2021 17:06
@casperdcl casperdcl force-pushed the devel branch 3 times, most recently from ecc308d to ff32f41 Compare January 5, 2021 17:16
github-actions[bot]
github-actions bot reviewed Jan 5, 2021
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 5, 2021
View reviewed changes
@NiftyPET NiftyPET deleted a comment from amypad-bot Jan 5, 2021
github-actions[bot]
github-actions bot reviewed Jan 6, 2021
View reviewed changes
github-actions[bot]
github-actions bot reviewed Jan 6, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@50c86d2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #13   +/-   ##
========================================
  Coverage          ?   6.80%           
========================================
  Files             ?       7           
  Lines             ?    1705           
  Branches          ?       0           
========================================
  Hits              ?     116           
  Misses            ?    1589           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c86d2...e6ab643. Read the comment docs.

@casperdcl casperdcl merged commit e6ff1a0 into master Jan 6, 2021
@casperdcl casperdcl deleted the devel branch January 6, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@pjmark pjmark Awaiting requested review from pjmark

Assignees

@casperdcl casperdcl

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casperdcl @pjmark