add add_raw function in rust bindings to add vector from raw bytes#35
Merged
Ngalstyan4 merged 2 commits intoNgalstyan4:main-lanternfrom Sep 27, 2024
Merged
Conversation
…ix typo in tests and benchmark
5347f8a to
67d1002
Compare
Ngalstyan4
reviewed
Sep 27, 2024
| _vector: &[Self], | ||
| _element_bits: usize, | ||
| ) -> Result<(), cxx::Exception> { | ||
| ffi::throw_not_implemented_exception()?; |
Owner
There was a problem hiding this comment.
does this function actually return? I'd think it would be -> ! so the nest line would not be necessary
Author
There was a problem hiding this comment.
tried to change the return type to -> ! , but the compiler complains that it do not match the return type specified in trait
Ngalstyan4
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.