Conversation
89af954 to
b0b419f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a preset is provided, the installation will be fully automated, avoiding UI delegate calls.
Does not address the issue with not having instructions returned by FOMOD
Closes Nexus-Mods/Vortex#18466
Tested by creating a collection with a single FOMOD mod, saving it and then reinstalling.
I've then confirmed that the code works by simply rebuilding the FOMOD installer, adding
Debugger.Launch()at the start of the executable and then switched thecreateIPCto always run viastartRegularand avoid the Sandboxed env.