Skip to content

Sets up i18n correctly #18642

Merged
IDCs merged 1 commit intomasterfrom
18641-i18n-foundationals
Oct 27, 2025
Merged

Sets up i18n correctly #18642
IDCs merged 1 commit intomasterfrom
18641-i18n-foundationals

Conversation

@insomnious
Copy link
Contributor

Closes #18641

This PR setups up our i18n correctly with local string resource files. It doesn't fix anything up til now but fixes the foundation for the future.

This will allow us to use the correct way with anything new and anything old we fix it as we touch it.

For example, when Collection Browsing is merged in...

Before

<h2>{t('Browse Collections ({{total}})', { total: numeral(allCollectionsTotal).format('0,0') })}</h2>

After

<h2>{t('collection:browse.title', { total: numeral(allCollectionsTotal).format('0,0') })}</h2>

Strings are located in out\locales\en\collection.json

{
  "browse": {
    "title": "Browse Collections ({{total}})",
    "selectGame": "Please select a game to browse collections.",
    "loading": "Loading collections...",
    "error": "Error loading collections:",
    "noCollections": "No collections found for this game.",
    "searchPlaceholder": "Search collections...",
    "resultsCount": "{{total}} results",
    "sortBy": "Sort by"
  },
  "pagination": {
    "goTo": "Go to:",
    "pageNumber": "Page number",
    "go": "Go"
  }
}

@insomnious insomnious self-assigned this Oct 27, 2025
@IDCs IDCs merged commit ea6ff58 into master Oct 27, 2025
1 check passed
@IDCs IDCs deleted the 18641-i18n-foundationals branch December 16, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix i18 functionality for string resources

2 participants