Skip to content

Conversation

@People-11
Copy link
Contributor

@People-11 People-11 commented Oct 20, 2025

Summary by Sourcery

Apply Pangu spacing format to messages during editing when enabled and ensure proper assignment of edited text and entities.

Enhancements:

  • Use toString() for assigning the edited message text.
  • Integrate Pangu formatting on message edits when not forwarded and enablePanguOnSending is enabled.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates ChatActivityEnterView.doneEditingMessage to apply Pangu spacing when editing messages and corrects text assignment and entity handling.

Sequence diagram for Pangu formatting during message editing

sequenceDiagram
participant User
participant ChatActivityEnterView
participant NaConfig
participant StringUtils
participant MessageObject

User->>ChatActivityEnterView: Edit message and submit
ChatActivityEnterView->>NaConfig: Check if Pangu is enabled
NaConfig-->>ChatActivityEnterView: Return enabled/disabled
alt Pangu enabled and message not forwarded
    ChatActivityEnterView->>StringUtils: spacingText(editingMessage, editingMessageEntities)
    StringUtils-->>ChatActivityEnterView: Return spaced text and updated entities
    ChatActivityEnterView->>MessageObject: Update editingMessage and editingMessageEntities
else Pangu not enabled or message forwarded
    ChatActivityEnterView->>MessageObject: Update editingMessage and editingMessageEntities (no spacing)
end
Loading

Class diagram for updated message editing logic in ChatActivityEnterView

classDiagram
class ChatActivityEnterView {
  +doneEditingMessage(withMarkdown)
}
class MessageObject {
  +editingMessage : String
  +editingMessageEntities : ArrayList<TLRPC.MessageEntity>
  +isForwarded() : boolean
}
class NaConfig {
  +INSTANCE : NaConfig
  +getEnablePanguOnSending() : BoolConfig
}
class BoolConfig {
  +Bool() : boolean
}
class StringUtils {
  +spacingText(text : String, entities : ArrayList<TLRPC.MessageEntity>) : Pair<String, ArrayList<TLRPC.MessageEntity>>
}
ChatActivityEnterView --> MessageObject : updates
ChatActivityEnterView --> NaConfig : checks config
ChatActivityEnterView --> StringUtils : applies spacing
NaConfig --> BoolConfig : getEnablePanguOnSending()
Loading

File-Level Changes

Change Details Files
Fix text assignment and ensure entity list consistency when editing messages
  • Use message[0].toString() instead of message[0] for string assignment
  • Initialize editingMessageEntities appropriately based on markdown flag
TMessagesProj/src/main/java/org/telegram/ui/Components/ChatActivityEnterView.java
Apply Pangu formatting to edited messages
  • Add conditional to check if message is not forwarded and Pangu is enabled
  • Invoke StringUtils.spacingText to adjust text and entities during editing
TMessagesProj/src/main/java/org/telegram/ui/Components/ChatActivityEnterView.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@omg-xtao omg-xtao changed the base branch from main to dev October 20, 2025 06:29
@omg-xtao omg-xtao merged commit 851ca8b into NextAlone:dev Oct 20, 2025
2 of 4 checks passed
@NextAlone
Copy link
Owner

给 nnn 也提一个 pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants