-
Notifications
You must be signed in to change notification settings - Fork 131
Pangu should work at editing messages too #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates ChatActivityEnterView.doneEditingMessage to apply Pangu spacing when editing messages and corrects text assignment and entity handling. Sequence diagram for Pangu formatting during message editingsequenceDiagram
participant User
participant ChatActivityEnterView
participant NaConfig
participant StringUtils
participant MessageObject
User->>ChatActivityEnterView: Edit message and submit
ChatActivityEnterView->>NaConfig: Check if Pangu is enabled
NaConfig-->>ChatActivityEnterView: Return enabled/disabled
alt Pangu enabled and message not forwarded
ChatActivityEnterView->>StringUtils: spacingText(editingMessage, editingMessageEntities)
StringUtils-->>ChatActivityEnterView: Return spaced text and updated entities
ChatActivityEnterView->>MessageObject: Update editingMessage and editingMessageEntities
else Pangu not enabled or message forwarded
ChatActivityEnterView->>MessageObject: Update editingMessage and editingMessageEntities (no spacing)
end
Class diagram for updated message editing logic in ChatActivityEnterViewclassDiagram
class ChatActivityEnterView {
+doneEditingMessage(withMarkdown)
}
class MessageObject {
+editingMessage : String
+editingMessageEntities : ArrayList<TLRPC.MessageEntity>
+isForwarded() : boolean
}
class NaConfig {
+INSTANCE : NaConfig
+getEnablePanguOnSending() : BoolConfig
}
class BoolConfig {
+Bool() : boolean
}
class StringUtils {
+spacingText(text : String, entities : ArrayList<TLRPC.MessageEntity>) : Pair<String, ArrayList<TLRPC.MessageEntity>>
}
ChatActivityEnterView --> MessageObject : updates
ChatActivityEnterView --> NaConfig : checks config
ChatActivityEnterView --> StringUtils : applies spacing
NaConfig --> BoolConfig : getEnablePanguOnSending()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg-xtao
requested changes
Oct 20, 2025
TMessagesProj/src/main/java/org/telegram/ui/Components/ChatActivityEnterView.java
Outdated
Show resolved
Hide resolved
omg-xtao
approved these changes
Oct 20, 2025
Owner
|
给 nnn 也提一个 pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Apply Pangu spacing format to messages during editing when enabled and ensure proper assignment of edited text and entities.
Enhancements: