Skip to content

feat: Disable contact phone number sharing prompt。 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NextAlone merged 1 commit into from
Apr 7, 2025
Merged

feat: Disable contact phone number sharing prompt。 #51

NextAlone merged 1 commit into from
Apr 7, 2025

Conversation

@cinitdev
Copy link
Contributor

@cinitdev cinitdev commented Apr 7, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Add an option to disable the contact phone number sharing prompt in the Telegram client

New Features:

  • Introduce a new configuration option to prevent showing the phone number sharing prompt for contacts

Enhancements:

  • Add a toggle in chat settings to control phone number sharing prompt visibility

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 7, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new feature that allows users to disable the contact phone number sharing prompt. This is achieved by adding a new configuration option and modifying the relevant UI logic to respect this setting.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new configuration option to disable the contact phone number sharing prompt.
  • Added a new disablePhoneSharePrompt configuration option in NaConfig.kt.
  • Added corresponding string resources in strings_na.xml and strings_na.xml (Chinese).
  • Added a new configuration option in NekoChatSettingsActivity.java.
  • Modified ChatActivity.java to check the new configuration option before showing the phone number sharing prompt.
 TMessagesProj/src/main/kotlin/xyz/nextalone/nagram/NaConfig.kt
TMessagesProj/src/main/res/values-zh-rCN/strings_na.xml
TMessagesProj/src/main/java/org/telegram/ui/ChatActivity.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/NekoChatSettingsActivity.java
TMessagesProj/src/main/res/values/strings_na.xml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 7, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cinitdev - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why disablePhoneSharePrompt is added to NekoChatSettingsActivity.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

NextAlone
NextAlone approved these changes Apr 7, 2025
View reviewed changes
Copy link
Owner

@NextAlone NextAlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NextAlone NextAlone merged commit dfcabc5 into NextAlone:dev Apr 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@NextAlone NextAlone NextAlone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cinitdev @NextAlone