Skip to content

feat: Support the operation of disabling the favorite shortcut label #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NextAlone merged 1 commit into from
Mar 12, 2025
Merged

feat: Support the operation of disabling the favorite shortcut label #49

NextAlone merged 1 commit into from
Mar 12, 2025

Conversation

@cinitdev
Copy link
Contributor

@cinitdev cinitdev commented Mar 12, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

New Features:

  • Adds a configuration option to disable favorite shortcut tag actions.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 12, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new configuration option to disable the favorite shortcut tag actions. This change allows users to disable the display of shortcut tags in the favorite actions.

Sequence diagram for disabling shortcut tag actions

sequenceDiagram
  participant User
  participant NekoChatSettingsActivity
  participant NaConfig
  participant Bulletin

  User->NekoChatSettingsActivity: Toggles "DisableShortcutTagActions" in settings
  NekoChatSettingsActivity->NaConfig: Sets disableShortcutTagActions to true
  NaConfig-->>Bulletin: Returns disableShortcutTagActions value
  Bulletin->Bulletin: Checks if NaConfig.disableShortcutTagActions is true
  alt disableShortcutTagActions is true
    Bulletin-->>User: Shortcut tag actions are disabled
  else disableShortcutTagActions is false
    Bulletin-->>User: Shortcut tag actions are enabled
  end
Loading

File-Level Changes

Change Details Files
Introduced a new configuration option to disable favorite shortcut tag actions.
  • Added a new config disableShortcutTagActions in NaConfig.kt.
  • Added a new preference item in NekoChatSettingsActivity.java to control the new config.
  • Added a new string resource for the preference item in strings_na.xml.
 TMessagesProj/src/main/kotlin/xyz/nextalone/nagram/NaConfig.kt
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/NekoChatSettingsActivity.java
TMessagesProj/src/main/res/values-zh-rCN/strings_na.xml
TMessagesProj/src/main/res/values/strings_na.xml
Conditionally disable shortcut tag actions based on the new configuration.
  • Added a check in Bulletin.java to disable shortcut tag actions based on the disableShortcutTagActions config.
 TMessagesProj/src/main/java/org/telegram/ui/Components/Bulletin.java
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 12, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cinitdev - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why disableShortcutTagActions is placed after disableTrendingFlags in NaConfig.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@NextAlone NextAlone merged commit e5f95b3 into NextAlone:dev Mar 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cinitdev @NextAlone