fix #521 - validator-blocker: add missing $ sign#522
Merged
stdevMac merged 1 commit intoNethermindEth:developfrom Nov 12, 2025
Merged
fix #521 - validator-blocker: add missing $ sign#522stdevMac merged 1 commit intoNethermindEth:developfrom
stdevMac merged 1 commit intoNethermindEth:developfrom
Conversation
khalifaa55
approved these changes
Oct 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #522 +/- ##
========================================
Coverage 24.13% 24.13%
========================================
Files 121 121
Lines 19672 19672
========================================
Hits 4748 4748
Misses 14380 14380
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521
Changes:
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
In case you checked yes, did you write tests?
Comments about testing , should you have some (optional)
Tested it localy on my mac machine as well as a VM with Ubuntu as a base image and the validator-blocker was configured correctly and succesfully exited when the depending deployments/healthcheck to validator response was 200 (OK).
Further comments (optional)
Not a complex PR, really simple fix and probably mergable/ready for merge.