Skip to content

feat: Add support for Hoodi on Lido CSM#506

Merged
AntiD2ta merged 8 commits intodevelopfrom
feat/hoodi-csm
Mar 27, 2025
Merged

feat: Add support for Hoodi on Lido CSM#506
AntiD2ta merged 8 commits intodevelopfrom
feat/hoodi-csm

Conversation

@khalifaa55
Copy link
Copy Markdown
Contributor

@khalifaa55 khalifaa55 commented Mar 26, 2025 •
edited
Loading

Changes:

  • Add support for Hoodi on Lido CSM

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

We will need to create a separate PR later on to add tests related to the node rewards with Hoodi on Lido.

@khalifaa55 khalifaa55 self-assigned this Mar 26, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.75%. Comparing base (fbe20e6) to head (43defa9).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #506   +/-   ##
========================================
  Coverage    24.75%   24.75%           
========================================
  Files          120      120           
  Lines        22315    22315           
========================================
  Hits          5525     5525           
  Misses       16246    16246           
  Partials       544      544
Flag Coverage Δ
unittests 24.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stdevMac
stdevMac requested changes Mar 26, 2025
View reviewed changes
@AntiD2ta AntiD2ta requested a review from stdevMac March 27, 2025 12:52
@AntiD2ta AntiD2ta merged commit 8a20914 into develop Mar 27, 2025
12 checks passed
@AntiD2ta AntiD2ta deleted the feat/hoodi-csm branch March 27, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntiD2ta AntiD2ta AntiD2ta approved these changes

@stdevMac stdevMac Awaiting requested review from stdevMac

Assignees

@khalifaa55 khalifaa55

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khalifaa55 @codecov-commenter @stdevMac @AntiD2ta