Skip to content

Change latest flag behavior#483

Merged
stdevMac merged 6 commits intodevelopfrom
fix/override_latest
Jan 24, 2025
Merged

Change latest flag behavior#483
stdevMac merged 6 commits intodevelopfrom
fix/override_latest

Conversation

@stdevMac
Copy link
Copy Markdown
Member

Changes:

  • Override --latest flag to not use the latest version of the image in the clients if image is specified

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 24.74%. Comparing base (07b369e) to head (23b40c0).

Files with missing lines Patch % Lines
internal/pkg/generate/generate_scripts.go 0.00% 10 Missing and 1 partial ⚠️
cli/generate.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #483      +/-   ##
===========================================
- Coverage    24.75%   24.74%   -0.01%     
===========================================
  Files          120      120              
  Lines        22305    22313       +8     
===========================================
  Hits          5521     5521              
- Misses       16239    16247       +8     
  Partials       545      545              
Flag Coverage Δ
unittests 24.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdevMac stdevMac merged commit c692dbd into develop Jan 24, 2025
@stdevMac stdevMac deleted the fix/override_latest branch January 24, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants