Skip to content

tests: Valid tests for Lido mainnet setup#467

Merged
khalifaa55 merged 9 commits intodevelopfrom
tests/lido-mainnet
Jan 20, 2025
Merged

tests: Valid tests for Lido mainnet setup#467
khalifaa55 merged 9 commits intodevelopfrom
tests/lido-mainnet

Conversation

@khalifaa55
Copy link
Copy Markdown
Contributor

@khalifaa55 khalifaa55 commented Oct 29, 2024 •
edited
Loading

Changes:

  • Uncomment valid tests for lido mainnet setup.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): tests

Further comments (optional)

We will have to keep this as a draft PR until the rewards tree for mainnet is up and we can get values for the node operators.

@khalifaa55 khalifaa55 self-assigned this Oct 29, 2024
@khalifaa55 khalifaa55 changed the title Valid tests for Lido mainnet steup Valid tests for Lido mainnet setup Nov 14, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.75%. Comparing base (a0d5bbb) to head (592c1da).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #467      +/-   ##
===========================================
+ Coverage    24.73%   24.75%   +0.02%     
===========================================
  Files          120      120              
  Lines        22299    22305       +6     
===========================================
+ Hits          5515     5521       +6     
  Misses       16239    16239              
  Partials       545      545
Flag Coverage Δ
unittests 24.75% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 marked this pull request as ready for review January 10, 2025 13:41
@khalifaa55 khalifaa55 changed the title Valid tests for Lido mainnet setup tests: Valid tests for Lido mainnet setup Jan 14, 2025
@khalifaa55 khalifaa55 merged commit 299ba6f into develop Jan 20, 2025
@khalifaa55 khalifaa55 deleted the tests/lido-mainnet branch January 20, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdevMac stdevMac stdevMac approved these changes

Assignees

@khalifaa55 khalifaa55

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khalifaa55 @codecov-commenter @stdevMac