Skip to content

Add e2e test cases for lido-exporter service integration#443

Merged
khalifaa55 merged 11 commits intodevelopfrom
tests/monitoringStack-e2e
Oct 15, 2024
Merged

Add e2e test cases for lido-exporter service integration#443
khalifaa55 merged 11 commits intodevelopfrom
tests/monitoringStack-e2e

Conversation

@khalifaa55
Copy link
Copy Markdown
Contributor

@khalifaa55 khalifaa55 commented Oct 10, 2024

Changes:

  • Update e2e test cases for monitoringStack with Grafana OnCall setup.
  • Include checks for alertmanager and alert rules in Prometheus directory.
  • Add test cases for lido-exporter service in monitoringStack

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): Add tests

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@khalifaa55 khalifaa55 self-assigned this Oct 10, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 44.81%. Comparing base (1f69582) to head (ba033e7).

Files with missing lines Patch % Lines
cli/monitoring.go 58.82% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #443      +/-   ##
===========================================
+ Coverage    44.78%   44.81%   +0.02%     
===========================================
  Files          115      115              
  Lines        10056    10070      +14     
===========================================
+ Hits          4504     4513       +9     
- Misses        5046     5050       +4     
- Partials       506      507       +1
Flag Coverage Δ
unittests 44.81% <61.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalifaa55 khalifaa55 marked this pull request as ready for review October 11, 2024 20:07
stdevMac
stdevMac approved these changes Oct 15, 2024
View reviewed changes
@khalifaa55 khalifaa55 merged commit cb6e42e into develop Oct 15, 2024
@khalifaa55 khalifaa55 deleted the tests/monitoringStack-e2e branch October 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdevMac stdevMac stdevMac approved these changes

Assignees

@khalifaa55 khalifaa55

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khalifaa55 @codecov-commenter @stdevMac