Merged
Conversation
Updates: - Strengthen client validation - Allow providing a list of RPC endpoints
6c43d24 to
b53a947
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #411 +/- ##
============================================
- Coverage 88.06% 44.34% -43.73%
============================================
Files 99 114 +15
Lines 5673 9797 +4124
============================================
- Hits 4996 4344 -652
- Misses 553 4991 +4438
- Partials 124 462 +338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stdevMac
requested changes
Sep 18, 2024
khalifaa55
approved these changes
Sep 18, 2024
stdevMac
approved these changes
Sep 19, 2024
Member
|
We should add documentation either on this PR or in other, about this new app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
Since there are two apps in the repo now, we have to create a PR after merging this to move app-specific packages to the app folder (the lido-exporter app has its own
clifolder for example). Thee2efolder is respecting this new structure and there is a suite implementation for each app (sedge and lido-exporter).#406 updates sedge's e2e test suite and test cases. The CI will likely fail for this PR since some critical changes and fixes are in #406.