Mev container display on holesky, even if not supported#322
Merged
Mev container display on holesky, even if not supported#322
Conversation
AntiD2ta
approved these changes
Oct 17, 2023
AntiD2ta
requested changes
Oct 17, 2023
Collaborator
AntiD2ta
left a comment
There was a problem hiding this comment.
There is no regression tests for this. There should be test cases for holesky that check there is no mev-boost config generated
Member
Author
Added test for that functionality at here 68a93fe |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #322 +/- ##
========================================
Coverage 86.13% 86.13%
========================================
Files 78 78
Lines 4558 4558
========================================
Hits 3926 3926
Misses 547 547
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
AntiD2ta
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Types of changes