Skip to content

Update Network Configs#314

Merged
AntiD2ta merged 4 commits intodevelopfrom
feat/update-networks-configs
Oct 13, 2023
Merged

Update Network Configs#314
AntiD2ta merged 4 commits intodevelopfrom
feat/update-networks-configs

Conversation

@cbermudez97
Copy link
Copy Markdown
Contributor

@cbermudez97 cbermudez97 commented Sep 26, 2023 •
edited
Loading

Changes:

  • Remove bootnodes from network configs
  • Remove custom configuration for Chiado

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@cbermudez97 cbermudez97 self-assigned this Sep 26, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 26, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (2d20170) to head (2126a55).
⚠️ Report is 132 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #314      +/-   ##
===========================================
- Coverage    86.76%   86.13%   -0.64%     
===========================================
  Files           78       78              
  Lines         4557     4557              
===========================================
- Hits          3954     3925      -29     
- Misses         518      547      +29     
  Partials        85       85
Flag Coverage Δ
unittests 86.13% <100.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AntiD2ta
AntiD2ta approved these changes Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! This requires smoke tests

@AntiD2ta AntiD2ta merged commit d28c33a into develop Oct 13, 2023
@AntiD2ta AntiD2ta deleted the feat/update-networks-configs branch October 13, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdevMac stdevMac stdevMac approved these changes

@AntiD2ta AntiD2ta AntiD2ta approved these changes

Assignees

@cbermudez97 cbermudez97

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbermudez97 @codecov-commenter @stdevMac @AntiD2ta