Fix NethermindEth/nethermind#10068 regression#530
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression by changing the ConsumeDataCopyGas method to allow gas to go negative instead of returning a boolean indicating insufficient gas. The change aligns with the "old Consume behavior" where negative gas is detected later in the VM execution rather than at the point of consumption.
Key Changes:
- Modified
ConsumeDataCopyGasto returnvoidinstead ofbooland useConsumeinstead ofUpdateGas - Updated tests to verify gas consumption and negative gas behavior instead of checking boolean return values
- Updated the Nethermind subproject commit reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Nethermind.Arbitrum/Evm/ArbitrumGasPolicy.cs | Changed ConsumeDataCopyGas method signature from returning bool to void, switched from UpdateGas to Consume for gas tracking |
| src/Nethermind.Arbitrum.Test/Evm/ArbitrumGasTests.cs | Updated test cases to verify gas consumption amounts and negative gas behavior instead of boolean success values |
| src/Nethermind | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
983b7f7 to
519f032
Compare
Contributor
Minimum allowed line rate is |
wurdum
approved these changes
Jan 6, 2026
svlachakis
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
ConsumeCodeCopyGasmethod nethermind#10068regression
Depends on