Skip to content

feat: Spec provider uses arbos version for building its release spec#143

Merged
hudem1 merged 5 commits into
mainfrom
hudem1/feat/chain-spec-uses-arbos-version
Aug 25, 2025
Merged

feat: Spec provider uses arbos version for building its release spec#143
hudem1 merged 5 commits into
mainfrom
hudem1/feat/chain-spec-uses-arbos-version

Conversation

@hudem1

@hudem1 hudem1 commented Aug 15, 2025

Copy link
Copy Markdown
Collaborator

Closes issue #134

It needs the following NMC PR

@hudem1 hudem1 requested a review from asdacap August 15, 2025 13:54
@hudem1 hudem1 force-pushed the hudem1/feat/chain-spec-uses-arbos-version branch from f8f5f07 to 1f58d79 Compare August 15, 2025 14:12
@hudem1 hudem1 force-pushed the hudem1/feat/chain-spec-uses-arbos-version branch from 1f58d79 to 799a699 Compare August 15, 2025 14:13
@codecov

codecov Bot commented Aug 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.46809% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.90%. Comparing base (b5a41ee) to head (448de8e).

Files with missing lines Patch % Lines
...nd.Arbitrum/Config/ArbitrumInitializeBlockchain.cs 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   83.96%   83.90%   -0.07%     
==========================================
  Files          89       91       +2     
  Lines        5134     5219      +85     
  Branches      731      733       +2     
==========================================
+ Hits         4311     4379      +68     
- Misses        823      840      +17     
Flag Coverage Δ
unittests 83.90% <74.46%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
src/Nethermind.Arbitrum/ArbitrumPlugin.cs 33.33% <100.00%> (+11.38%) ⬆️
src/Nethermind.Arbitrum/Arbos/ArbosState.cs 89.18% <ø> (ø)
src/Nethermind.Arbitrum/Arbos/ArbosVersion.cs 100.00% <100.00%> (ø)
...itrum/Config/ArbitrumChainSpecBasedSpecProvider.cs 100.00% <100.00%> (ø)
...bitrum/Config/ArbitrumChainSpecEngineParameters.cs 100.00% <100.00%> (+7.69%) ⬆️
.../Nethermind.Arbitrum/ContainerBuilderExtensions.cs 100.00% <100.00%> (ø)
...nd.Arbitrum/Config/ArbitrumInitializeBlockchain.cs 11.86% <0.00%> (-10.87%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a41ee...448de8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wurdum wurdum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AnkushinDaniil AnkushinDaniil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Comment thread src/Nethermind.Arbitrum/Config/ArbitrumInitializeBlockchain.cs
@hudem1 hudem1 requested a review from svlachakis as a code owner August 21, 2025 12:26
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Nethermind.Arbitrum 78% 54%
Summary 78% (4824 / 6206) 54% (1321 / 2431)

Minimum allowed line rate is 60%

@hudem1 hudem1 merged commit b43eee5 into main Aug 25, 2025
5 checks passed
@hudem1 hudem1 deleted the hudem1/feat/chain-spec-uses-arbos-version branch August 25, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants