Skip to content

Adjusting estimateGas response to match geth responses for execution …#9485

Merged
mrzeszutko merged 2 commits into
masterfrom
bugfix/fix-estimate-gas-execution-reverted-response
Oct 16, 2025
Merged

Adjusting estimateGas response to match geth responses for execution …#9485
mrzeszutko merged 2 commits into
masterfrom
bugfix/fix-estimate-gas-execution-reverted-response

Conversation

@mrzeszutko

Copy link
Copy Markdown
Contributor

…reverted

Fixes some issues with the implementation in #9428 - now both Error(string) ABI encoded errors as well as reverts without ABI encoding are handled as expected by hive tests.

Changes

  • Added correct handling of revert errors for eth_estimateGas

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes
  • No

@mrzeszutko mrzeszutko merged commit 6561007 into master Oct 16, 2025
80 checks passed
@mrzeszutko mrzeszutko deleted the bugfix/fix-estimate-gas-execution-reverted-response branch October 16, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants