Fix/hunting flaky tests#9470
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses flaky test issues by implementing retry mechanisms and adjusting timeout configurations for synchronization and network discovery tests. The changes aim to improve test stability in CI environments by accommodating timing variability.
Key changes:
- Added retry attributes and parallelization control to reduce test flakiness
- Increased timeout values for background operations to allow more time for async processes
- Improved variable type specification for better code clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Nethermind/Nethermind.Synchronization.Test/SyncServerTests.cs | Added retry/parallelization attributes, increased timeout from 8s to 15s, and specified variable type |
| src/Nethermind/Nethermind.Network.Discovery.Test/E2EDiscoveryTests.cs | Added retry/parallelization attributes and increased timeout from 1s to 5s |
Member
Author
|
Passed on first try! |
benaadams
approved these changes
Oct 15, 2025
flcl42
approved these changes
Oct 15, 2025
asdacap
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?