feat: implement proper block validation in BlockchainTestBase to mimic sync manager behavior#9438
Merged
LukaszRozmej merged 7 commits intoOct 17, 2025
Conversation
12 tasks
flcl42
requested changes
Oct 13, 2025
Contributor
|
In case of troubles with some tests - try |
flcl42
requested changes
Oct 15, 2025
flcl42
reviewed
Oct 16, 2025
flcl42
approved these changes
Oct 17, 2025
LukaszRozmej
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements proper block validation in
BlockchainTestBase.RunTest()to mimic sync manager behavior, addressing TODO on line 188.Changes
ValidateSuggestedBlock()before suggesting blocksValidateSeal()when seal engine is usedImpact
Tests now follow the same validation flow as
SyncServer.SyncBlock()for more accurate blockchain testing.