Skip to content

PluginOrder Refactoring#9308

Merged
svlachakis merged 9 commits into
masterfrom
healthchecks-remove-consensus-rule
Sep 19, 2025
Merged

PluginOrder Refactoring#9308
svlachakis merged 9 commits into
masterfrom
healthchecks-remove-consensus-rule

Conversation

@svlachakis

@svlachakis svlachakis commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Removed consensus plugin prioritization - They no longer automatically load first
  • PluginConfig is the sole ordering mechanism - Whatever is in PluginOrder determines the sequence
  • Fallback to alphabetical - Plugins not in the config sort alphabetically
  • Adjusted tests

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Sync Supported Chains Job https://github.com/NethermindEth/nethermind/actions/runs/17795109499

@svlachakis svlachakis requested a review from asdacap September 17, 2025 10:38

@LukaszRozmej LukaszRozmej left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make canse insensitive?
Replaces #9254

Comment thread src/Nethermind/Nethermind.Api/Extensions/PluginLoader.cs Outdated
Comment thread src/Nethermind/Nethermind.Api/Extensions/PluginLoader.cs Outdated
Comment thread src/Nethermind/Nethermind.Api/Extensions/PluginLoader.cs Outdated

@LukaszRozmej LukaszRozmej left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but needs testing

@svlachakis svlachakis merged commit 0a06d62 into master Sep 19, 2025
79 checks passed
@svlachakis svlachakis deleted the healthchecks-remove-consensus-rule branch September 19, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants