Skip to content

keep VirtualMachineBase in the same file#9033

Merged
tanishqjasoria merged 1 commit into
feature/arbitrum-setupfrom
tanishq/arb-merge
Jul 25, 2025
Merged

keep VirtualMachineBase in the same file#9033
tanishqjasoria merged 1 commit into
feature/arbitrum-setupfrom
tanishq/arb-merge

Conversation

@tanishqjasoria

Copy link
Copy Markdown
Contributor

Keeping them in the same file makes syncing with master much easier.

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@hudem1 hudem1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanishqjasoria tanishqjasoria merged commit 70a269e into feature/arbitrum-setup Jul 25, 2025
60 of 63 checks passed
@tanishqjasoria tanishqjasoria deleted the tanishq/arb-merge branch July 25, 2025 03:24
@damian-orzechowski damian-orzechowski mentioned this pull request Sep 4, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants