Make gas price and premium gas calculation overridable#8993
Merged
damian-orzechowski merged 1 commit intoJul 21, 2025
Merged
Conversation
wurdum
approved these changes
Jul 15, 2025
MarekM25
approved these changes
Jul 15, 2025
LukaszRozmej
approved these changes
Jul 15, 2025
LukaszRozmej
left a comment
Member
There was a problem hiding this comment.
Should those be virtual methods, or separate strategies?
hudem1
approved these changes
Jul 16, 2025
Contributor
Author
With the current way we override tx processing, I'd keep it virtual methods, but in the future we could think of redesigning it to cover different strategies e.g. to calculate intrinsic gas or calc effective price (if that is what you meant). |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make gas price and premium gas calculation overridable in classed derived from transaction processor.
Changes
Make the following calculations as virtual methods of
TransactionProcessorfor ease of overriding:Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?