Skip to content

refactor(init): replace fixed delay with event-driven block processing readiness#8948

Merged
AnkushinDaniil merged 2 commits into
feature/arbitrum-setupfrom
daniil/block-processing-readiness
Jul 8, 2025
Merged

refactor(init): replace fixed delay with event-driven block processing readiness#8948
AnkushinDaniil merged 2 commits into
feature/arbitrum-setupfrom
daniil/block-processing-readiness

Conversation

@AnkushinDaniil

@AnkushinDaniil AnkushinDaniil commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Fixes Closes Resolves #63

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

…g readiness

- Add ProcessingCompletedTask to IBlockProcessingQueue for async readiness signaling
- Implement TaskCompletionSource-based readiness in BlockchainProcessor
- Refactor RegisterPluginRpcModules to await true block processing completion
- Remove all arbitrary delays and polling from plugin RPC module initialization
- Ensures RPC modules are only enabled after all blocks are processed, eliminating race conditions and startup lag
@AnkushinDaniil AnkushinDaniil marked this pull request as ready for review July 7, 2025 10:38
Comment thread src/Nethermind/Nethermind.Consensus/Processing/IBlockProcessingQueue.cs Outdated
@AnkushinDaniil AnkushinDaniil merged commit 3e549ad into feature/arbitrum-setup Jul 8, 2025
178 of 182 checks passed
@AnkushinDaniil AnkushinDaniil deleted the daniil/block-processing-readiness branch July 8, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants