Skip to content

Remove Nethermind.Cli#8575

Merged
benaadams merged 5 commits into
masterfrom
feature/no-nethermind-cli
May 6, 2025
Merged

Remove Nethermind.Cli#8575
benaadams merged 5 commits into
masterfrom
feature/no-nethermind-cli

Conversation

@rubo

@rubo rubo commented May 1, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Removed Nethermind.Cli
  • Removed unnecessary NuGet packages
  • Replaced Nethermind.Cli API in the SendBlobs tool with Nethereum.JsonRpc.RpcClient package BasicJsonRpcClient as discussed with @flcl42
  • The distribution packages are shrunk in size by almost half (e.g., from 175 MB to 100 MB)
  • Packages build times are now shorter

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

The SendBlobs tool requires manual testing

Documentation

Requires documentation update

  • Yes
  • No

The docs have been updated with some samples of popular libraries.

Requires explanation in Release Notes

  • Yes
  • No

Nethermind.Cli has been removed from the distribution packages as deprecated.

@rubo rubo requested review from LukaszRozmej and flcl42 May 1, 2025 16:56
@rubo rubo marked this pull request as ready for review May 2, 2025 18:33
@rubo rubo requested a review from a team May 2, 2025 18:33
@rubo rubo marked this pull request as draft May 5, 2025 14:19
@rubo rubo marked this pull request as ready for review May 5, 2025 17:39
@benaadams benaadams merged commit 31a12ad into master May 6, 2025
79 checks passed
@benaadams benaadams deleted the feature/no-nethermind-cli branch May 6, 2025 07:34
@rubo rubo mentioned this pull request May 7, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants