Skip to content

Add metrics for engine_getBlobsV1 full and partial responses#8495

Merged
marcindsobczak merged 1 commit into
masterfrom
feature/get_blobs_metrics
Apr 15, 2025
Merged

Add metrics for engine_getBlobsV1 full and partial responses#8495
marcindsobczak merged 1 commit into
masterfrom
feature/get_blobs_metrics

Conversation

@marcindsobczak

Copy link
Copy Markdown
Contributor

Changes

  • add metrics NumberOfGetBlobsSuccesses and NumberOfGetBlobsFailures
    A successful response to engine_getBlobsV1 may include some (or even all) null values, indicating that the requested blobs are not available. We already track metrics for the number of blobs requested and the number of blobs sent, and based on that, we estimate the return rate on mainnet to be around 85%. For now, partial responses (some blobs returned, some nulls) are useful for the CL.
    However, after Fusaka's PeerDAS, partial responses will no longer be useful - CL will require either all requested blobs or none. This PR introduces new metrics to track fully successful responses (where all requested blobs are returned) versus successful but incomplete responses (where some blobs are missing). These metrics will help us estimate the rate of fully successful responses, which are critical for PeerDAS.
    These metrics are already included in the PeerDAS branch, but we also want to start collecting data from mainnet.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@benaadams benaadams left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should rationalize (remove) some metrics 🤔

@marcindsobczak

Copy link
Copy Markdown
Contributor Author

After Fusaka, we can remove NumberOfRequestedBlobs and NumberOfSentBlobs, as partial responses will no longer be useful. For now, however, they remain important. The metrics introduced in this PR aren't critical at the moment, but they will help us collecting data for PeerDAS and we’ll need to add them eventually anyway.

@benaadams

Copy link
Copy Markdown
Member

After Fusaka..

Mostly meant other metrics 😀

@marcindsobczak marcindsobczak merged commit 265d04b into master Apr 15, 2025
@marcindsobczak marcindsobczak deleted the feature/get_blobs_metrics branch April 15, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants