Use Nethermind as Optimism Sequencer#7287
Merged
Merged
Conversation
emlautarom1
commented
Jul 24, 2024
emlautarom1
commented
Jul 24, 2024
emlautarom1
commented
Jul 26, 2024
emlautarom1
commented
Jul 26, 2024
| public class OptimismEthRpcModuleTest | ||
| { | ||
| [Test] | ||
| public async Task Sequencer_send_transaction_with_signature_will_not_try_to_sign() |
Contributor
Author
There was a problem hiding this comment.
This test is pretty much a copy/paste of:
- Only run in Sequencer mode when asked to
This reverts commit bbebda9.
jmederosalvarado
approved these changes
Jul 31, 2024
flcl42
approved these changes
Jul 31, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Documentation
Requires documentation update
We don't have an Optimism section on the Nethermind docs yet.
Requires explanation in Release Notes
Remarks
Used the following
args.yamlfile for the ethpandas optimism kurtosis package:The
emlautarom1/op-nethermindimage was built locally from this PRs branch usingNote that the Dockerfile.chiseled version does not work in this scenario.