Skip to content

Boot nodes to debug log#11805

Merged
benaadams merged 1 commit into
masterfrom
bootnodes
May 28, 2026
Merged

Boot nodes to debug log#11805
benaadams merged 1 commit into
masterfrom
bootnodes

Conversation

@benaadams

Copy link
Copy Markdown
Member

Changes

  • Move to debug log as it happens fairly frequently and isn't very interesting
image

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • No

@claude

claude Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Claude finished @benaadams's task in 51s —— View job


Review

  • Gather context
  • Read changed file and diff
  • Review the change

Change: Kademlia.cs:129IsInfo/InfoIsDebug/Debug for the "Online bootnodes" count message.

Verdict: LGTM. The change is correct and well-motivated.

A few observations that confirm this is the right call:

  • Consistency with surrounding log levels. Bootnode ping failures (line 125) and the "Bootstrap completed" summary (lines 146–150) are already at Debug. The onlineBootNodes count now aligns with the same verbosity tier as the other bootstrap diagnostics.
  • Frequency. Bootstrap is called in a tight loop in Run (line 84–102), sleeping only _refreshInterval between iterations. The screenshot in the PR body shows the message firing every ~10 seconds, flooding Info logs with low-value data.
  • No operational loss. The count is useful for connectivity debugging, not routine monitoring — operators who need it can enable Debug logging. There is no equivalent Info-level signal that would cover this gap.
  • Guard + call pair updated consistently. Both _logger.IsDebug and _logger.Debug(...) were changed together — no mismatch.

No findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces log noise during discovery bootstrapping by downgrading the “Online bootnodes” message from info to debug in the Kademlia discovery loop.

Changes:

  • Changed “Online bootnodes” logging from Info to Debug in Kademlia.Bootstrap.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LukaszRozmej LukaszRozmej left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a part of regular peer report?
Like make this code update a metric - and use it there?

@benaadams benaadams merged commit 82590cb into master May 28, 2026
551 checks passed
@benaadams benaadams deleted the bootnodes branch May 28, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants