Add StatsAnalyzer to build pipeline#11766
Merged
Merged
Conversation
PR #11573 (Bal devnet 7 benchmarks) split the unified BlockAccessList type into ReadOnlyBlockAccessList / GeneratedBlockAccessList / BlockAccessListAtIndex but missed ParallelExecutionStopgapTests, which still referenced the old name and so failed CS0246 on every build of tools/StatsAnalyzer/StatsAnalyzer.slnx. Block.BlockAccessList is now ReadOnlyBlockAccessList?, so the test's BuildBlock/RunSingleBlock parameters follow suit and the `new()` calls use target-typed form to satisfy IDE0090. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The StatsAnalyzer.slnx tool is in tools/ but was not listed in the build-tools matrix, so its build status was never verified per-commit. This let PR #11573's BlockAccessList -> ReadOnlyBlockAccessList type rename break the StatsAnalyzer plugin test (CS0246) and ship to master undetected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @Marchhill's task in 41s —— View job PR Review: Add StatsAnalyzer to build pipeline
SummaryThis PR adds a single line to Findings: none.
Verdict: ready to merge. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the StatsAnalyzer tool solution to the existing “Build tools” GitHub Actions workflow so it is built as part of the tools CI matrix.
Changes:
- Include
StatsAnalyzer/StatsAnalyzer.slnxin thebuild-tools.ymlmatrix to ensure it’s compiled in CI alongside other tools.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LukaszRozmej
approved these changes
May 26, 2026
batrr
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes