Fix statsanalyzer plugin BAL rename#11760
Merged
Merged
Conversation
PR #11573 (Bal devnet 7 benchmarks) split the unified BlockAccessList type into ReadOnlyBlockAccessList / GeneratedBlockAccessList / BlockAccessListAtIndex but missed ParallelExecutionStopgapTests, which still referenced the old name and so failed CS0246 on every build of tools/StatsAnalyzer/StatsAnalyzer.slnx. Block.BlockAccessList is now ReadOnlyBlockAccessList?, so the test's BuildBlock/RunSingleBlock parameters follow suit and the `new()` calls use target-typed form to satisfy IDE0090. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @Marchhill's task in 1m 4s —— View job Review
This is a straightforward, correct fix. Here's what I verified: Correctness
Coverage of stale references
Style
No findings. The change is minimal, accurate, and complete.
|
batrr
approved these changes
May 26, 2026
LukaszRozmej
approved these changes
May 26, 2026
Member
|
This plugin is not added to our build pipelines? If not it should be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #11573 (Bal devnet 7 benchmarks) split the unified BlockAccessList type into ReadOnlyBlockAccessList / GeneratedBlockAccessList / BlockAccessListAtIndex but missed ParallelExecutionStopgapTests, which still referenced the old name and so failed CS0246 on every build of tools/StatsAnalyzer/StatsAnalyzer.slnx.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes