Skip to content

Fix statsanalyzer plugin BAL rename#11760

Merged
Marchhill merged 1 commit into
masterfrom
fix/statsanalyzer-bal-rename
May 26, 2026
Merged

Fix statsanalyzer plugin BAL rename#11760
Marchhill merged 1 commit into
masterfrom
fix/statsanalyzer-bal-rename

Conversation

@Marchhill

Copy link
Copy Markdown
Contributor

PR #11573 (Bal devnet 7 benchmarks) split the unified BlockAccessList type into ReadOnlyBlockAccessList / GeneratedBlockAccessList / BlockAccessListAtIndex but missed ParallelExecutionStopgapTests, which still referenced the old name and so failed CS0246 on every build of tools/StatsAnalyzer/StatsAnalyzer.slnx.

Changes

  • Rename

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

PR #11573 (Bal devnet 7 benchmarks) split the unified BlockAccessList
type into ReadOnlyBlockAccessList / GeneratedBlockAccessList /
BlockAccessListAtIndex but missed ParallelExecutionStopgapTests, which
still referenced the old name and so failed CS0246 on every build of
tools/StatsAnalyzer/StatsAnalyzer.slnx.

Block.BlockAccessList is now ReadOnlyBlockAccessList?, so the test's
BuildBlock/RunSingleBlock parameters follow suit and the `new()` calls
use target-typed form to satisfy IDE0090.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Marchhill's task in 1m 4s —— View job


Review

  • Gather context
  • Read changed file
  • Check for other stale references in the codebase
  • Post review findings

This is a straightforward, correct fix. Here's what I verified:

Correctness

  • Block.BlockAccessList property is typed ReadOnlyBlockAccessList? in Block.cs — the updated parameter types in BuildBlock and RunSingleBlock match exactly.
  • ReadOnlyBlockAccessList has a parameterless constructor (public ReadOnlyBlockAccessList() : this([], 0) { } at ReadOnlyBlockAccessList.cs:64), so the three new BlockAccessList()new() (target-typed new) conversions are valid and resolve to ReadOnlyBlockAccessList.
  • The block!.BlockAccessList = bal assignment lines are unchanged and correct — they reference the property name, not the old type name.

Coverage of stale references

  • No remaining BlockAccessList type name (as opposed to the property) references exist anywhere under tools/StatsAnalyzer/. The grep confirms only two remaining hits, both referencing the block.BlockAccessList property name in the tracer implementation, which are correct.

Style

  • Using new() instead of new ReadOnlyBlockAccessList() is idiomatic C# 9+ target-typed new and avoids repeating the type name — fine choice.

No findings. The change is minimal, accurate, and complete.

Verdict: approve

@LukaszRozmej

Copy link
Copy Markdown
Member

This plugin is not added to our build pipelines? If not it should be added.

@Marchhill Marchhill merged commit 06dc8e9 into master May 26, 2026
545 checks passed
@Marchhill Marchhill deleted the fix/statsanalyzer-bal-rename branch May 26, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants