test(sync): un-ignore Can_cancel_seal_validation#11744
Merged
LukaszRozmej merged 1 commit intoMay 25, 2026
Merged
Conversation
`[Ignore("Fails OneLoggerLogManager Travis only")]` was added back when
the repo still ran on Travis CI. Travis was retired years ago and the
test has been silently skipped since.
Re-running locally on the current `Nethermind.Synchronization.Test`
project the test passes cleanly — 20 consecutive standalone runs and 39
sibling `ForwardHeaderProvider*` tests in the same fixture all green.
Drop the attribute so it executes in normal CI again and gives us real
coverage of `IForwardHeaderProvider.GetBlockHeaders` cancellation when
seal validation is slow.
LukaszRozmej
approved these changes
May 25, 2026
batrr
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Nethermind.Synchronization.Test.ForwardHeaderProviderTests.Can_cancel_seal_validationhas been[Ignore]d since the Travis CI days with the comment"Fails OneLoggerLogManager Travis only". Travis was retired years ago and the test has been silently skipped ever since — meaning we have had zero real coverage ofIForwardHeaderProvider.GetBlockHeaderscancellation when seal validation is slow.release/net10.0, the test passes cleanly: 20 consecutive standalone runs and the fullForwardHeaderProvider*fixture (39 tests) all green.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
The PR is the test re-enablement; no new test added. Verified locally with 20x stress runs (all pass) plus the surrounding 39-test fixture (all pass). Will be visible in CI on this branch.
Documentation
Requires documentation update
Requires explanation in Release Notes