Skip to content

Reset GasUsed when simulating txs#10766

Merged
flcl42 merged 2 commits into
masterfrom
estimate-no-gas-used
Mar 10, 2026
Merged

Reset GasUsed when simulating txs#10766
flcl42 merged 2 commits into
masterfrom
estimate-no-gas-used

Conversation

@flcl42

@flcl42 flcl42 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #10552

Changes

  • Reset GasUsed when simulating txs

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

I'd suggest to check the spec additionally for whether we should limit estimations by block gas limit also?

@flcl42 flcl42 merged commit 24747b5 into master Mar 10, 2026
111 checks passed
@flcl42 flcl42 deleted the estimate-no-gas-used branch March 10, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eth_estimateGas intermittently returns incorrect results / reverts on v1.36.0 (regression from v1.35.x)

3 participants