refactor: remove redundant HexConvert class#10045
Closed
dizer-ti wants to merge 1 commit into
Closed
Conversation
alexb5dh
reviewed
Dec 26, 2025
Contributor
Author
|
@LukaszRozmej @alexb5dh could you please align on whether to keep ToUInt64 or remove it entirely? |
Member
Yeah agree with @alexb5dh that suggestion was suboptimal and previous was better on |
bc8bba9 to
5d349b9
Compare
Contributor
Author
|
Done! Kept ToUInt64, replaced only ToUInt256 with UInt256.Parse. |
b7d8c9b to
3a2e1d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10033 (comment)
Remove HexConvert class and use standard methods instead: