Allowing partial success in batch requests.#1070
Merged
juanfranblanco merged 3 commits intoNethereum:masterfrom Mar 21, 2025
Merged
Allowing partial success in batch requests.#1070juanfranblanco merged 3 commits intoNethereum:masterfrom
juanfranblanco merged 3 commits intoNethereum:masterfrom
Conversation
dlebee
commented
Mar 21, 2025
| errors.Add(new RpcError(response.Error.Code, response.Error.Message + ": " + batchItem.RpcRequestMessage.Method, | ||
| response.Error.Data)); | ||
| batchItem.DecodeResponse(response); | ||
| errors.Add(new RpcError(response.Error.Code, response.Error.Message + ": " + batchItem.RpcRequestMessage.Method, response.Error.Data)); |
Contributor
Author
There was a problem hiding this comment.
I could use batchItem.RpcError to add to errors, but the RpcError object wasn't created the same way, so just in case people expected a specific string already, i did not want to break their compability.
dlebee
commented
Mar 21, 2025
Contributor
Author
dlebee
left a comment
There was a problem hiding this comment.
added a comment about why i kept the error.
…tch item behaves as expected now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Goal of this PR is to allow batch request to partially fail.