BigInteger explicit cast and FloorToBigInteger for BigDecimal#1055
Merged
juanfranblanco merged 6 commits intoNethereum:masterfrom Nov 25, 2024
ethanrushh:master
Merged
BigInteger explicit cast and FloorToBigInteger for BigDecimal#1055juanfranblanco merged 6 commits intoNethereum:masterfrom ethanrushh:master
juanfranblanco merged 6 commits intoNethereum:masterfrom
ethanrushh:master
Conversation
breaking change: Return type of Floor() no longer supports BigDecimal properties such as .Mantissa
…void breaking changes
Contributor
Author
|
Changed Floor to no longer be a BigInteger, added FloorToBigInteger. Explicit cast remains the same. Updated tests and use cases where BigDecimal was being floored. No longer will be a breaking change. |
Member
|
Many Thanks @ethanrushh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the return type of BigDecimal.Floor() from BigDecimal to BigInteger. Also implements a cast that returns the truncated BigDecimal (so same as calling Floor). This is to mimic the behaviour of other casts (e.g. float -> int, decimal -> int) that also truncate on cast.Breaking change: Calling BigDecimal.Floor() will now return a BigIntgerAdds BigInteger explicit cast and FloorToBigInteger, and associated tests.