fyi, I test this with a vanilla argo-workflows create command and everything was fine.

As an additional note, the newly added Sensors for argo-workflows from #1271 would also require labeling. If you have time, this could be done in the scope of this PR.

I personally would like to get this merged as quickly as possible. I can look into this but I haven't used Sensors so I would also need to look into that. If it's easy, I can do it, but otherwise I would like to create a new PR.

We can do another PR for the sensors, they are just another template that is being compiled as part of argo-workflows create so should be straightforward to add the labels support for those. I might have time today to look into it.

Could you resolve the conflicts with this branch so it is ready for merging?

We can do another PR for the sensors, they are just another template that is being compiled as part of argo-workflows create so should be straightforward to add the labels support for those. I might have time today to look into it.

Could you resolve the conflicts with this branch so it is ready for merging?

Conflicts resolved. Thanks for your help.

Tested the latest with:

METAFLOW_KUBERNETES_LABEL="" python hello.py run --with kubernetes
METAFLOW_KUBERNETES_LABEL="label1=val1" python hello.py run --with kubernetes
METAFLOW_KUBERNETES_LABEL="label1=val1,label2=val2" python hello.py run --with kubernetes
METAFLOW_KUBERNETES_LABEL="label=creation" python hello.py argo-workflows create
METAFLOW_KUBERNETES_LABEL="label=trigger" python hello.py argo-workflows trigger  # label has no effect here, the creation label is used
METAFLOW_KUBERNETES_LABEL="" python hello.py argo-workflows create
python hello.py run --with kubernetes:labels=l1=v1  # this also fails as expected

Sensor Labels: dhpollack#1