Migrate to com.palantir.javapoet#902
Merged
iuliiasobolevska merged 1 commit intoNetflix:masterfrom Dec 11, 2025
Merged
Conversation
- Replace `com.squareup:javapoet` dependency with the latest version (0.9.x) of `com.palantir.javapoet:javapoet`. - Update imports to use the new package names. - Use the accessor methods to get the field values from JavaPoet objects, rather than accessing those fields directly, as the fields are now marked as private in the respective Palantir's JavaPoet classes. - Use the builder wrapper object to access the current state of `TypeSpec.Builder`, as the builder classes no longer expose their internal state via public methods. - Use Object class name constant from `ClassName` class, as the similar constant in `TypeName` class no longer exists. - Make minor refactoring changes suggested by IntelliJ IDEA's code inspector tool.
Contributor
Author
Collaborator
|
This is great @illegal, thanks! We'll do some testing on our repos |
iuliiasobolevska
approved these changes
Dec 11, 2025
Collaborator
|
@illegal we tested this change on 100+ repos and didn't see issues, so we went ahead and merged. Thanks again for this work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.squareup:javapoetdependency with the latest version (0.9.x) ofcom.palantir.javapoet:javapoet.TypeSpec.Builder, as the builder classes no longer expose their internal state via public methods.ClassNameclass, as the similar constant inTypeNameclass no longer exists.