Add support for generating default URI values#887
Merged
Conversation
iparadiso
approved these changes
Oct 27, 2025
sjohnr
approved these changes
Oct 27, 2025
iuliiasobolevska
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #885 (comment) which removed generating non-compiling string default values for non-string Java types, to add URI support which seems like it would be a common case.
This PR adds explicit support for generating default values for
java.net.URIfields usingURI.create(). The data type generator validates the URI before generating by wrapping an internal call toURI.create()in a try-catch and errors if the provided URI is invalid. The user must still provide thetypeMappingfromUritojava.net.URI.schema.graphqls:
Movie.java: