Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Add support for building on windows#3831

Merged
v1r3n merged 1 commit intoNetflix:mainfrom
Robban1980:update_for_windows_build
Nov 25, 2023
Merged

Add support for building on windows#3831
v1r3n merged 1 commit intoNetflix:mainfrom
Robban1980:update_for_windows_build

Conversation

@Robban1980
Copy link
Contributor

@Robban1980 Robban1980 commented Nov 2, 2023

Pull Request type

  • [ x] Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • [ x] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed
When pulling the repository to a windows machine git will automatically convert the files line ending to windows format (CRLF). This however is not compatible with Gradle. To prevent git from automatically changing these when the repository is pulled, the .gitattribute file has been updated and the below lines have been added.

*.gradle eol=lf
*.java eol=lf
*.groovy eol=lf
spring.factories eol=lf
*.sh eol=lf

Alternatives considered

Describe alternative implementation you have considered

@Robban1980 Robban1980 marked this pull request as ready for review November 2, 2023 01:49
@v1r3n v1r3n merged commit 921981f into Netflix:main Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants