This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Fix: include monaco sources into bundle#3796
Merged
v1r3n merged 2 commits intoNetflix:mainfrom Nov 12, 2023
Merged
Conversation
9844f91 to
dc30fab
Compare
v1r3n
approved these changes
Nov 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Our Conductor service is deployed in an offline environment, but currently the monaco-editor package calls external js files:
Therefore, the monaco-editor package needs to be bundled into the Docker image: suren-atoyan/monaco-react#168 (comment)
Alternatives considered
Describe alternative implementation you have considered