This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Removing TaskDef retryCount cap of 10.#3729
Merged
v1r3n merged 1 commit intoNetflix:mainfrom Aug 11, 2023
Merged
Conversation
v1r3n
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Removed the TaskDef retryCount Cap that was set to 10
Describe the new behavior from this PR, and why it's needed
Issue #
Some of the workflows and the architecture is designed to work on the high retryCount. Capping it to 10 is breaking things on our side.
Alternatives considered
Instead of removing the Cap, making it configurable.
Describe alternative implementation you have considered