This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Added the ability to inject a custom AmazonS3 client#3699
Merged
v1r3n merged 2 commits intoNetflix:mainfrom Jul 23, 2023
Merged
Added the ability to inject a custom AmazonS3 client#3699v1r3n merged 2 commits intoNetflix:mainfrom
v1r3n merged 2 commits intoNetflix:mainfrom
Conversation
Konstantin-Posudevskiy
approved these changes
Jul 19, 2023
v1r3n
approved these changes
Jul 23, 2023
v1r3n
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
I've added ability to initialize AmazonS3 Client as a separate Bean.
If someone use a S3 compatible storage (e.g. Pure Storage), they will be able to initialize AmazonS3 in their @configuration like in the example below and this client will be used for initializing S3PayloadStorage
Disable default client:
Initialisation my own client:
Discussion: #3693
Alternatives considered
Describe alternative implementation you have considered