Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

Fixed Docker issues#3680

Merged
v1r3n merged 3 commits intoNetflix:mainfrom
JCHacking:fixed-docker-issues-build
Jul 25, 2023
Merged

Fixed Docker issues#3680
v1r3n merged 3 commits intoNetflix:mainfrom
JCHacking:fixed-docker-issues-build

Conversation

@JCHacking
Copy link
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Fixed bugs when building docker images
Issue #3632

@frankkeefer
Copy link

I'd love to see this merged in, so we don't have to manual update the docker files locally to build the ui image. Any chance this can be merged?

@GabrielOctavianPopa
Copy link

Bump

@charlesmelby
Copy link

This should be merged as the tutorials don't work without this and information about the problem isn't forthcoming.
In addition, in principle dependencies should be managed such that docker builds don't break.

@v1r3n v1r3n merged commit d0a5883 into Netflix:main Jul 25, 2023
@JCHacking JCHacking deleted the fixed-docker-issues-build branch July 25, 2023 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants