This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Handling messages loss case on exceptions#3585
Merged
v1r3n merged 7 commits intoNetflix:mainfrom Apr 19, 2023
Merged
Conversation
When message has no transient failures, only logically unhandled exception - message was being Acked. In our case - message that it's handler metadata wasn't fetched successfully (Connection with Redis was down). In this case we would expect it to- 1.Be retried (transient failure) - Handled with adding transient exception catching in RedisEventHandlerDao 2. In general, only messages that passed successfully, without any type of exception - will be Acked. Messages that we want by config to be republished on failure OR have exceptions that are transient - to be published back to queue. Only other failing messages - to be Nacked.
added 2 commits
April 19, 2023 17:42
v1r3n
approved these changes
Apr 19, 2023
Contributor
|
@AvitalOfstein can you run the spotless and update the PR? |
added 4 commits
April 19, 2023 23:10
…cur. Moved to the test with transient exception, that required republish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
When message has no transient failures, only logically unhandled exception - message was being Acked. In our case - message that it's handler metadata wasn't fetched successfully (for example, Connection with Redis was down).
In this case we would expect it to-
1.Be retried (transient failure) - Handled with adding transient exception catching in RedisEventHandlerDao
2. In general, we would like only messages that passed successfully, without any type of exception - will be Acked. Messages that we want by config to be republished on failure OR have exceptions that are transient - to be published back to queue. Only other failing messages - to be Nacked.