This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Fix disappearing outputs from long running tasks#3573
Merged
v1r3n merged 1 commit intoNetflix:mainfrom Apr 11, 2023
Merged
Conversation
with external storage enabled In case of a: 1. Long running task 2. With big output (externalized) 3. With output growing over time 4. Causing multiple externalize / internalize executions 5. ... such as a join task collecting outputs of all forked tasks 6. Lost some of its outputs when finally completed This issue was caused by / because: 1. On an Nth execution of a task (such as described above) 2. The task internalized its intermediate output from external storage 3. The task was executed and it updated its output to current value in memory 4. The task tried to externalize the new version of its output 5. ... but while doing so, the outputPayload (last externalized value) was combined with outputData (current, in-memory value) in a way where output payload over-wrote the latest values 6. Thus, newly calculated outputs have been lost Signed-off-by: Maros Marsalek <mmarsalek@frinx.io>
Contributor
Author
|
@v1r3n hey, we found this issue when running with external storage. Please take a look, it's just a 1 liner |
v1r3n
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with external storage enabled
In case of a:
This issue was caused by / because:
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered